I think I have addressed the feedback, please let me know if there's anything else to do. The git history is messy, I'm planning to squash it when this code is considered ready to merge.
I've also added a live test. I haven't been able to check that *all* the live tests pass because I get an error that I think is unrelated to my changes when I try to run them. I'm following the instructions [here](http://jclouds.incubator.apache.org/documentation/devguides/provider-testing/). ```Shell francis@murr swift $ mvn -Plive clean install -Dtest.cloudfiles-uk.identity=<redacted> -Dtest.cloudfiles-uk.credential=<redacted> ... ------------------------------------------------------- T E S T S ------------------------------------------------------- Running TestSuite Configuring TestNG with: org.apache.maven.surefire.testng.conf.TestNG652Configurator@4a4e79f1 org.apache.maven.surefire.util.SurefireReflectionException: java.lang.reflect.InvocationTargetException; nested exception is java.lang.reflect.InvocationTargetException: null java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75) Caused by: org.testng.TestNGException: org.jclouds.blobstore.integration.internal.BaseContainerLiveTest.testPublicAccessInNonDefaultLocationWithBigBlob() is depending on method public void org.jclouds.blobstore.integration.internal.BaseContainerLiveTest.testPublicAccess() throws java.lang.InterruptedException,java.net.MalformedURLException,java.io.IOException, which is not annotated with @Test or not included. at org.testng.internal.MethodHelper.findDependedUponMethods(MethodHelper.java:111) at org.testng.internal.MethodHelper.topologicalSort(MethodHelper.java:240) at org.testng.internal.MethodHelper.sortMethods(MethodHelper.java:317) at org.testng.internal.MethodHelper.collectAndOrderMethods(MethodHelper.java:59) at org.testng.TestRunner.initMethods(TestRunner.java:481) at org.testng.TestRunner.init(TestRunner.java:235) at org.testng.TestRunner.init(TestRunner.java:205) at org.testng.TestRunner.<init>(TestRunner.java:153) at org.testng.SuiteRunner$DefaultTestRunnerFactory.newTestRunner(SuiteRunner.java:522) at org.testng.SuiteRunner.init(SuiteRunner.java:157) at org.testng.SuiteRunner.<init>(SuiteRunner.java:111) at org.testng.TestNG.createSuiteRunner(TestNG.java:1273) at org.testng.TestNG.createSuiteRunners(TestNG.java:1260) at org.testng.TestNG.runSuitesLocally(TestNG.java:1114) at org.testng.TestNG.run(TestNG.java:1031) at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:77) at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeMulti(TestNGDirectoryTestSuite.java:159) at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:99) at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:106) ... 9 more Results : Tests run: 0, Failures: 0, Errors: 0, Skipped: 0 [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ ``` --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/123#issuecomment-23101449
