I just re-deployed the dashboard with the mentioned changes.

The left column now shows the PRs that still don't have CI comments or
that are currently failing the build (last failure is more recent than
last ok); the middle column shows the PRs where the build is OK (last
success is more recent than last failure), and the right column shows
those PRs that someone has +1'ed (this just looks for a +1 in the
comments, so this could be improved a bit).

I've refactored a bit the code and now all the customization is done
here [1]. Also added a couple comments, to show what each method does,
but it shouldn't be difficult to read! :)


[1] 
https://github.com/nacx/code-review-dashboard/blob/jclouds/plugins/jclouds.py

On 26 August 2013 08:37, Ignasi <[email protected]> wrote:
> Currently it just counts the success/failures without taking into account
> the comment date (which sucks :)).
>
> I have a couple changes in progress to make the dashboard more customizable
> that I plan to upload this afternoon. I'll fix the jenkins counters and try
> to have the new version with all the changes deployed by then!
>
> El 24/08/2013 20:45, "Andrew Phillips" <[email protected]> escribió:
>
>>> global vision of all of them, which ones pass the build, which ones
>>> are old ones, and which ones have some +1.
>>
>>
>> What's the criterion for "Jenkins Happy", by the way? The PRs listed seem
>> to have at least one successful build (from BuildHive? DEV@cloud?), but also
>> some failures:
>>
>> jclouds JCLOUDS-251: Swift: Delete chunks when deleting a multipart blob
>> (frankoid)
>> 0 likes / 52 comments / 0 days old
>> 22 success / 2 failures
>>
>> Most in the Need More Work column have at least one failure (some
>> successes, too), but some look like they should't be there?
>>
>> jclouds-karaf [JCLOUDS-225] Configured itests to use the generated repo.
>> (iocanel)
>> 0 likes / 16 comments / 18 days old
>> 1 success / 0 failures
>>
>> Or is "Need More Work" something like "can't be built"?
>>
>> Thanks!
>>
>> ap

Reply via email to