> +   @ConstructorProperties({
> +      "name", "cooldown", "minEntities", "maxEntities", "metadata"
> +   })
> +   protected GroupConfiguration(String name, int cooldown, int minEntities, 
> int maxEntities, Map<String,String> metadata) {
> +
> +      this.name = checkNotNull(name, "name required");
> +      checkArgument(cooldown >= 0, "cooldown should be non-negative");
> +      checkArgument(minEntities >= 0, "minEntities should be non-negative");
> +      checkArgument(maxEntities >= 0, "maxEntities should be non-negative");
> +      this.cooldown = cooldown;
> +      this.minEntities = minEntities;
> +      this.maxEntities = maxEntities;
> +      this.metadata = metadata;
> +      if(metadata == null) {
> +         this.metadata = Maps.newHashMap();
> +      }

Inline to avoid the reassignation? `this.metadata = metadata == null? 
Maps.newHashMap() : metadata;`

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/22/files#r6073657

Reply via email to