> @@ -163,6 +197,7 @@ public IpPermission(IpProtocol ipProtocol, int fromPort, > int toPort, > this.ipProtocol = checkNotNull(ipProtocol, "ipProtocol"); > this.groupIds = ImmutableSet.copyOf(checkNotNull(groupIds, > "groupIds")); > this.cidrBlocks = ImmutableSet.copyOf(checkNotNull(cidrBlocks, > "cidrBlocks")); > + this.ports = ports == null ? TreeRangeSet.<Integer>create() : ports;
Rather than make this nullable, how about having a legacy constructor that would pass an empty RangeSet (rather than null). Then we could hopefully use the same `copyOf` construction. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/145/files#r6228660
