> @@ -177,4 +177,7 @@
>  
>     @SinceApiVersion("0.10.0")
>     Iterable<? extends Environment> listEnvironmentsNamed(Iterable<String> 
> names);
> +
> +   @SinceApiVersion("0.10.0")
> +   Iterable<? extends Node> listEnvironmentNodes(String environmentName);

Well, the thing I'm thinking about here is that "listX" might be expected to 
return X. I know that "listEnvironmentNodes" ends in "Nodes", but to have 
"listEnvironments" return environments and a method that looks really similar 
return something else might be a bit confusion.

In fact, I might even go so far as to suggest that this could be
```
Iterable<Node> listNodes(String environmentName, ...)
```
That, to me, would align most neatly on the Java side, but it _does_ diverge 
from the Chef API a bit (I wonder why they made that specific choice?).

So OK with leaving this if it's a pattern you'd like to continue for the 
remainder of the `/environment/...` API calls.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/13/files#r6239087

Reply via email to