Was originally part of https://github.com/jclouds/jclouds/pull/147 - see @jdtoy 
's comment:

    "NL-NH" is probably most accurate for Amsterdam.

And my response there:

    @jdtoy thanks, but I'll leave it as "NL" for this pull 
request if that's ok.

    I think in another part of the softlayer integration code we're also 
extracting the datacenter's iso3166 automatically from the json returned by 
softlayer, which gives us "country":"NL". There's a 
test that asserts the extracted string is contained within the set of iso3166 
codes hard-coded in the softlayer metadata (which you spotted). So changing the 
hard-coded value would break the test, until we did some more work...
You can merge this Pull Request by running:

  git pull https://github.com/aledsage/jclouds 
fix/softlayer-getAssignableLocations-missing-NL

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/149

-- Commit Summary --

  * Fix softlayer getAssignableLocations: missing NL

-- File Changes --

    M 
providers/softlayer/src/main/java/org/jclouds/softlayer/SoftLayerProviderMetadata.java
 (2)
    M 
providers/softlayer/src/test/java/org/jclouds/softlayer/compute/SoftLayerTemplateBuilderLiveTest.java
 (2)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/149.patch
https://github.com/jclouds/jclouds/pull/149.diff

Reply via email to