> + * limitations under the License.
> + */
> +package org.jclouds.compute.extensions.options;
> +
> +
> +import static com.google.common.base.Objects.equal;
> +
> +import com.google.common.base.Objects;
> +
> +/**
> + * Options supported by {@code VolumeExtension#detachVolume}.
> + *
> + * APIs/providers implementing @{link VolumeExtension} will generally wish to
> + * extend DetachVolumeOptions, as is done with @{link TemplateOptions}
> + */
> +public class DetachVolumeOptions implements Cloneable {

so I'd remove the device field from this and punt to a list of devices in
an EC2 subtype


On Thu, Sep 19, 2013 at 8:17 PM, Andrew Bayer <[email protected]>wrote:

> In
> compute/src/main/java/org/jclouds/compute/extensions/options/DetachVolumeOptions.java:
>
> > + * limitations under the License.
> > + */
> > +package org.jclouds.compute.extensions.options;
> > +
> > +
> > +import static com.google.common.base.Objects.equal;
> > +
> > +import com.google.common.base.
> Objects;
> > +
> > +/**
> > + * Options supported by {@code VolumeExtension#detachVolume}.
> > + *
> > + * APIs/providers implementing @{link VolumeExtension} will generally wish 
> > to
> > + * extend DetachVolumeOptions, as is done with @{link TemplateOptions}
> > + */
> > +public class DetachVolumeOptions implements Cloneable {
>
> CloudStack doesn't require the instance ID for detaching, EC2 and Nova do.
> CloudStack and Nova don't do anything with device for detaching, but EC2
> apparently does allow attaching to multiple devices, 'cos it does take the
> device as a parameter for detaching.
>
> —
> Reply to this email directly or view it on 
> GitHub<https://github.com/jclouds/jclouds/pull/109/files#r6468343>
> .
>

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/109/files#r6469124

Reply via email to