> @@ -171,8 +171,7 @@ private void appendPayloadMetadata(HttpRequest request,
> StringBuilder buffer) {
> void appendHttpHeaders(HttpRequest request, StringBuilder toSign) {
> // Only the value is used, not the header
> // name. If a request does not include the header, this is an empty
> string.
> - for (String header : new String[] { "Range" })
> -
> toSign.append(HttpUtils.nullToEmpty(request.getHeaders().get(header)).toLowerCase()).append("\n");
> +
> toSign.append(HttpUtils.nullToEmpty(request.getHeaders().get("Range")).toLowerCase()).append("\n");
The above changes preserve the existing behavior of the code (i.e., no
functional changes) but, are you assuming there could be multiple Range
headers? I do not believe that is legal according to spec but I could be wrong:
The Atmos Programmer's Manual has a link to
http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.35. There is also
https://svn.tools.ietf.org/svn/wg/httpbis/draft-ietf-httpbis/latest/p1-messaging.html#field.order.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/163/files#r6680665
