While this patch probably violates good design principles because of
the imperfect location of the cache, exposing the params cache outside
of RestAnnotationProcessor to S3Utils results in a roughly 40%
improvement in performance for generating signed GETs and PUTs for
S3. This commit also converts a few others calls to
Invokable.getParameters() but the observed benefit from those was
small in my microbenchmarks.

This is related to JCLOUDS 301.
You can merge this Pull Request by running:

  git pull https://github.com/maginatics/jclouds params_cache

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/164

-- Commit Summary --

  * [RFC]: Make increased use of Invokable params cache

-- File Changes --

    M apis/s3/src/main/java/org/jclouds/s3/util/S3Utils.java (3)
    M core/src/main/java/org/jclouds/rest/internal/RestAnnotationProcessor.java 
(10)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/164.patch
https://github.com/jclouds/jclouds/pull/164.diff

Reply via email to