So there were a few problems, but the core ugly one is that what you
pass in for creating a rule allowing groups' access is not the same
thing you get back from a group with such a rule, which makes mapping
between the arguments and the output insanely painful. So now, well,
we do some insanely painful stuff.
You can merge this Pull Request by running:

  git pull https://github.com/abayer/jclouds-1 fix-nova-sge

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/167

-- Commit Summary --

  * Fix OpenStack Nova SecurityGroupExtension based on live tests

-- File Changes --

    M 
apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/extensions/NovaSecurityGroupExtension.java
 (98)
    M 
apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/functions/NovaSecurityGroupInZoneToSecurityGroup.java
 (2)
    M 
apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/functions/SecurityGroupRuleToIpPermission.java
 (50)
    M 
apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/extensions/NovaSecurityGroupExtensionExpectTest.java
 (48)
    M 
apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/functions/NovaSecurityGroupInZoneToSecurityGroupTest.java
 (13)
    M 
apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/functions/NovaSecurityGroupToSecurityGroupTest.java
 (42)
    M 
apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/compute/functions/SecurityGroupRuleToIpPermissionTest.java
 (13)
    M 
apis/openstack-nova/src/test/resources/securitygroup_details_extension.json (4)
    M apis/openstack-nova/src/test/resources/securitygroup_list_extension.json 
(8)
    M 
compute/src/test/java/org/jclouds/compute/extensions/internal/BaseSecurityGroupExtensionLiveTest.java
 (5)
    A 
providers/hpcloud-compute/src/test/java/org/jclouds/hpcloud/compute/compute/extensions/HPCloudComputeSecurityGroupExtensionLiveTest.java
 (41)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/167.patch
https://github.com/jclouds/jclouds/pull/167.diff

Reply via email to