Hey guys, In the CloudStackComputeServiceAdapter function createNodeWithGroupEncodedIntoName there are some additional action after the node is created. Most notably the configuration of static nat. When that call fails the node is still created, but users of the api will expect a failure.
What should be the correct behaviour here, should i change the method to detect this exception, delete the created node and rethrow. Or should i expect the api user to check if the node was created and destroy it again. I'm testing now with the first solution, but i wanted to check if that is the right way to do it before submitting a review. Cheers, Hugo
