> -            logger.debug(">> creating static NAT for virtualMachine(%s) in 
> network(%s)", vm.getId(), networkId);
> -            PublicIPAddress ip = 
> staticNATVMInNetwork.create(networks.get(networkId)).apply(vm);
> -            logger.trace("<< static NATed IPAddress(%s) to 
> virtualMachine(%s)", ip.getId(), vm.getId());
> -            vm = 
> client.getVirtualMachineClient().getVirtualMachine(vm.getId());
> -            List<Integer> ports = 
> Ints.asList(templateOptions.getInboundPorts());
> -            if (capabilities.getCloudStackVersion().startsWith("2")) {
> -               logger.debug(">> setting up IP forwarding for IPAddress(%s) 
> rules(%s)", ip.getId(), ports);
> -               Set<IPForwardingRule> rules = 
> setupPortForwardingRulesForIP.apply(ip, ports);
> -               logger.trace("<< setup %d IP forwarding rules on 
> IPAddress(%s)", rules.size(), ip.getId());
> -            } else {
> -               logger.debug(">> setting up firewall rules for IPAddress(%s) 
> rules(%s)", ip.getId(), ports);
> -               Set<FirewallRule> rules = setupFirewallRulesForIP.apply(ip, 
> ports);
> -               logger.trace("<< setup %d firewall rules on IPAddress(%s)", 
> rules.size(), ip.getId());
> -            }
> -         }
> +      try {

Where in this block are exceptions thrown? Could we narrow the scope of the 
`try`?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/184/files#r6996419

Reply via email to