Sorry it's taken me so long to get to this. Before we get into the code review 
a few things.

- [ ] The PR should have its own branch.

PRs should never be done on master. Please create a branch.

- [ ] All live tests should have the class annotation @Test(groups = "live")

This includes the live tests that are already part of openstack-neutron (sorry 
I didn't spot this before)

- [ ] The live tests should work with OpenStack Havana

I know Havana was just released but we need to be as forward looking as 
possible. OpenStack moves to quickly to do otherwise.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/36#issuecomment-26687764

Reply via email to