Couple of general comments that apply to many parts of the code: * I think we prefer Immutable*.Builders to Maps.newHashMap(), Lists.newArrayList() etc., unless we know there are `null` values * There are some exception messages in `bindToRequest` that may be correct, but may also be copy-paste artifacts * The "target value as string but apply clever parsing logic" everywhere seems unnecessarily duplicated - can we put that in one of the domain objects rather than sprinkling it all over our parsing? * We seem to be doing quite a lot of manual JSON maps-to-domain object parsing ourselves here - is there a way to get our web frameworks to do more of this for us? * Remove APIs from this PR that are actually only placeholders and submit them as a separate PR once they're actually in progress?
--- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/39#issuecomment-27154534
