> + assertEquals(request.getFilters().get(0).getClass(),
> JoyentBlobRequestSigner.class);
> + }
> +
> + @Override
> + public JoyentProviderMetadata createProviderMetadata() {
> + return new JoyentProviderMetadata();
> + }
> +
> + protected java.util.Properties setupProperties() {
> + Properties overrides = super.setupProperties();
> + overrides.setProperty(Constants.PROPERTY_IDENTITY,
> TestConstants.USER_NAME);
> + overrides.setProperty(JoyentConstants.JOYENT_CERT_FINGERPRINT,
> TestConstants.CERT_FINGERPRINT);
> + overrides.setProperty(JoyentConstants.JOYENT_CERT_CLASSPATH,
> TestConstants.CERT_CLASSPATH);
> + return overrides;
> + }
> +}
It is great that you added the tests for the Joyent API class, however, this
kind of unit tests are deprecated and we no longer tests the APIs this way. Now
we use [mockwebserver](https://code.google.com/p/mockwebserver/) for unit
testing as it gives us a more complete test path. You can take a look at the
OpenStack Swift tests to see how it works (for example you can take a look at
the
[ContainerApiMockTest](https://github.com/jclouds/jclouds-labs-openstack/blob/master/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/ContainerApiMockTest.java)
test class).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/30/files#r7243045
