> +         // Network corresponding to security group does not exist.
> +         return null;
> +      }
> +
> +      ListOptions options = new ListOptions.Builder().filter("network eq 
> .*/" + group.getName());
> +
> +      if 
> (api.getFirewallApiForProject(userProject.get()).list(options).concat().anyMatch(providesIpPermission(ipPermission)))
>  {
> +         // Permission already exists.
> +         return group;
> +      }
> +
> +      FirewallOptions fwOptions = new FirewallOptions();
> +      String uniqueFwName = 
> namingConvention.createWithoutPrefix().uniqueNameForGroup(group.getName());
> +      fwOptions.name(uniqueFwName);
> +      fwOptions.network(group.getUri());
> +      if (ipPermission.getGroupIds().size() > 0) {

`!ipPermission.getGroupIds().isEmpty()`?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/5/files#r7379260

Reply via email to