> +                                        Iterable<String> ipRanges,
> +                                        Iterable<String> groupIds, 
> SecurityGroup group) {
> +      IpPermission.Builder permBuilder = IpPermission.builder();
> +      permBuilder.ipProtocol(protocol);
> +      permBuilder.fromPort(startPort);
> +      permBuilder.toPort(endPort);
> +      permBuilder.tenantIdGroupNamePairs(tenantIdGroupNamePairs);
> +      permBuilder.cidrBlocks(ipRanges);
> +      permBuilder.groupIds(groupIds);
> +
> +      return addIpPermission(permBuilder.build(), group);
> +   }
> +
> +   @Override
> +   public SecurityGroup removeIpPermission(IpPermission ipPermission, 
> SecurityGroup group) {
> +      String id = checkNotNull(group.getId(), "group.getId()");

Yeah, adding the ipPermission null check.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/152/files#r7385357

Reply via email to