thanks 

Simon




From:
Andy Seaborne <a...@apache.org>
To:
dev@jena.apache.org
Date:
08/11/2012 01:13 PM
Subject:
Re: TransformFilterEquality



On 10/08/12 22:21, Simon Helsen wrote:
> Actually, what I suggested is not quite correct it. It should be line 
130
> which should be changed from
>
>   if ( op instanceof OpJoin )
>
> to
>
>   if ( op instanceof OpJoin || op instanceof OpUnion)
>
> since there is no special requirement on unions as far as I can see (so
> line 137 should be left alone)

Yes - the leftjoin related ones have additional rules due to different 
scoping as they recombine their eval'ed subexpressions.

Added (with tests) in svn.

                 Thanks,
                 Andy



Reply via email to