[ 
https://issues.apache.org/jira/browse/JENA-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553213#comment-13553213
 ] 

Andy Seaborne commented on JENA-370:
------------------------------------

I have managed to apply the patch!

I applied it to jena-core as of today (14/Jan).

testReadLocalNTriple and testReadLocalRDF:
I've moved their resources to src/test/resources.

((
Usually, in Jena we put tesing material under testing/ not use classpath 
loading because the
testing/ area includes copies of W3C WG materials.  Sometimes it's a lot of 
files so managing
explicitly as files is easier.
))

testEventDeletedByFind -- renamed to ignore_testEventDeletedByFind - the trun k 
gets built every night and a test failure will block that.

Code commit with those two changes only - then more commits to start cleaning 
up the warning.

Unclear:

ModelTestBase is marked @Deprecated but a lot of tests rely on the the statics.
Similarly com.hp.hpl.jena.regression.TestCaseBasic and it is the only file in 
the package now and @Deprecated

If I un-deprecate those two I have 32 warnings (with deprecation, 352) which 
look fixable.

What should be done about these classes?
                
> No test cases for alternative Model implementations
> ---------------------------------------------------
>
>                 Key: JENA-370
>                 URL: https://issues.apache.org/jira/browse/JENA-370
>             Project: Apache Jena
>          Issue Type: Test
>          Components: Jena
>    Affects Versions: Jena 2.7.4
>            Reporter: Claude Warren
>         Attachments: JENA-370-2.10.patch, JENA370-afs-1.patch, 
> jena-370-core-2.10-attempt2.patch, jena=370-core-2.10.patch, JENA-370.patch, 
> JENA-370.patch
>
>
> The Model tests are all hard coded to use the 
> ModelFactory.createDefaultModel() (and similar) model constructors.  This 
> makes it impossible for alternative implementations to verify they meet the 
> interface contracts.  
> One solution is to convert the tests to use a getModel() method ala the 
> getGraph() method used for the graph tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to