[ 
https://issues.apache.org/jira/browse/JENA-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13723810#comment-13723810
 ] 

Andy Seaborne commented on JENA-488:
------------------------------------

To me, a better test would be just check not null.  The assumption tested was 
dubious in core Jena (that's why there is setReaderClassName!). So, unless, 
like testMissingReader() the class is set by the test, a class test is not very 
useful.

{noformat}
    public void testGetNTripleReader()
    {
        final RDFReader reader = model.getReader("N-TRIPLE");
        Assert.assertNotNull(reader) ;
    }
{noformat}
Can we fix/close this now?
                
> TestReaders.testGetNTripleReader() is dependent upon ARQ not being loaded.
> --------------------------------------------------------------------------
>
>                 Key: JENA-488
>                 URL: https://issues.apache.org/jira/browse/JENA-488
>             Project: Apache Jena
>          Issue Type: Bug
>          Components: Jena, RIOT
>    Affects Versions: Jena 2.10.1
>            Reporter: Claude Warren
>            Assignee: Claude Warren
>              Labels: easyfix
>
> The testGetNTripleReader test assumes that the NTriple reader will be an 
> instance of NTripleReader, which is correct if ARQ has not been loaded.  When 
> ARQ has been loaded the result is an instance of RDFReaderRIOT.  
> This bug is to fix the test to accept RDFReaderRIOT or NTripleReader as valid 
> results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to