On 09/12/13 11:57, Andy Seaborne wrote:
Looks very good.
I've applied the patch jena-text-graph-with-tests.diff to the code base
and committed it to svn trunk.
I added the patch to the JIRA for the record. BTW - you can add files
directly. JIRA is not restricted to project committers.
One matter arising:
jena.textindexer
If I do:
rm -rf Lucene/* ; rm -f DB/* ; tdbloader --loc DB D.trig
textindexer --desc config-tdb-text.ttl
I get:
-------------
value cannot be null
-------------
Something has eaten the stacktrace.
I can't find that message in the code base so it might be coming from a
java library.
No indexing started.
D.trig:
---------------
prefix : <http://example/>
prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#>
:s rdfs:label "This is :s" .
---------------
Commenting out
text:graphField "graph" ;
and then no error so it looks to be related to that field.
Found and fixed.
(Sidenote: I think the current jena-text index code also won't
gracefully handle resources with a bnode subject. The
getBlankNodeLabel() result gets stored in the index and is then
considered a URI at query time, though it isn't really and probably
won't match the original triples in the store.)
Found and fixed.
Blank nodes go into the index as "_:...."
In-progress - the textindexing command line tool does not work properly.
There is some duplicated code (bad!) which needs consolidating.
Andy
