[
https://issues.apache.org/jira/browse/JENA-662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13946804#comment-13946804
]
Jeremy Carroll commented on JENA-662:
-------------------------------------
The method getDirectoryName in
com.hp.hpl.jena.assembler.assemblers.FileModelAssembler does look incorrect to
me: it does not appear to decode. The RIOT code does appear correct with a very
quick review
{noformat}
private String getDirectoryName( Resource root )
{
return getRequiredResource( root, JA.directory ).getURI().replaceFirst(
"file:", "" );
}
{noformat}
> Wrong space handling in FileModelAssembler
> ------------------------------------------
>
> Key: JENA-662
> URL: https://issues.apache.org/jira/browse/JENA-662
> Project: Apache Jena
> Issue Type: Bug
> Components: Jena
> Affects Versions: Jena 2.11.1
> Reporter: Natanael Arndt
> Priority: Minor
>
> The method {{getDirectoryName}} in
> {{com.hp.hpl.jena.assembler.assemblers.FileModelAssembler}} should also make
> sure that at some chars, like space should be urldecoded again. E.g. If the
> URI is {{file:///tmp/file%20name%20with%20space}} the corresponding file can
> not be found under {{/tmp/file%20name%20with%20space}} but under {{/tmp/file
> name with space}}.
> There might be some other chars which have to be taken into account, e.g.
> "%25" -> "%", but I don't think a urldecode over the whole string is correct.
> Sorry I can't provide an example yet, because I couldn't isolate this part of
> the code so far and I didn't try to write a test for this.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
