[
https://issues.apache.org/jira/browse/JENA-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gert van Valkenhoef updated JENA-808:
-------------------------------------
Attachment: 0001-TestDifference-fix-argument-order-in-assertIsomorphi.patch
Thank you for handling this quickly & smoothly!
I've looked at the code, and it seems that in the assertIsomorphic() calls in
TestDifference (but not the other tests), the actual and expected are reversed
compared to my local branch. According to GraphTestBase:290, the expected comes
first, so my local branch is probably correct. This may have something to do
with the out-of-order patch you ran into. I've attached another patch to fix
this.
> De-deprecate Difference, Delta, and Intersection
> ------------------------------------------------
>
> Key: JENA-808
> URL: https://issues.apache.org/jira/browse/JENA-808
> Project: Apache Jena
> Issue Type: Wish
> Components: Jena
> Affects Versions: Jena 2.12.1
> Environment: Any
> Reporter: Gert van Valkenhoef
> Assignee: Andy Seaborne
> Fix For: Jena 2.12.2
>
> Attachments: 0001-Give-test-more-accurate-name.patch,
> 0001-TestDifference-fix-argument-order-in-assertIsomorphi.patch,
> 0002-Refactor-graph.compose.Delta-and-add-tests.patch,
> 0003-Add-tests-for-graph.compose.Difference.patch,
> 0004-Use-assertIsomorphic-instead-of-assertEquivalent.patch,
> 0005-Add-unit-tests-for-Intersection.patch,
> 0006-Add-unit-tests-for-Union.patch
>
>
> In JENA-59 it was mentioned that the Difference, Delta, and Intersection
> classes were deprecated due to a lack of tests. I am using these in an
> implementation of the Event Sourcing pattern (see
> http://github.com/gertvv/jena-es/).
> I am willing to implement additional tests if this helps remove the
> deprecations and make them a stable part of Jena. Is this something you would
> consider?
> Can you give concrete examples of what is currently missing and/or provide an
> example of a similar but well-tested class? I had a look at the tests for
> Union (which is not deprecated), but they don't appear to be any more
> comprehensive.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
