[ 
https://issues.apache.org/jira/browse/JENA-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262887#comment-14262887
 ] 

Andy Seaborne commented on JENA-839:
------------------------------------

{{NodeFunctions.checkAndGetStringLiteral}} is called from several other places, 
not just E_Regex.  I think these are OK but I'd like to see the consequences.  

It is also used in {{checkTwoArgumentStringLiterals}} for the [argument 
compatibility 
rules|http://www.w3.org/TR/sparql11-query/#func-arg-compatibility].

There are possible unexpected effects : xsd:normalizedString concat 
xsd:normalizedString will be a xsd:string.


> E_Regex only works with XSDstring.
> ----------------------------------
>
>                 Key: JENA-839
>                 URL: https://issues.apache.org/jira/browse/JENA-839
>             Project: Apache Jena
>          Issue Type: Bug
>          Components: ARQ
>    Affects Versions: Jena 2.12.1
>         Environment: Linux
>            Reporter: Claude Warren
>            Assignee: Claude Warren
>
> E_Regex eval verifies the argument is a string using: 
> {noformat}
> Node arg = NodeFunctions.checkAndGetStringLiteral("REGEX", args.get(0)) ;
> {noformat}
>  NodeFunctions.checkAndGetStringLiteral verifies that if the nodevalue is not 
> null and is an XSDstring by the following statement:
> {noformat}
>  if ( dt != null && !dt.equals(XSDDatatype.XSDstring) )
>             throw new ExprEvalException(label + ": Not a string literal: " + 
> nv) ;
> {noformat}
> this means that other string types (e.g. XSDnormalizedString) fail.
> I believe that the check should be to check that dt is an instanceof 
> XSDBaseStringType.
> I am looking for comment before making the change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to