On 02/02/15 11:53, Stian Soiland-Reyes wrote:
Did you mean to just include the jena-osgi.jar in the apache-jena/
dist? It would add only 7 MB.
I think it's a different audience.
apache-jena-dist is for standalong use + source + javadoc.
I'd rather start cautious and add later, rather than add now and feel
obliged to continue that.
If on the otherside we do a separate download of jena-osgi, we
probably want a separate 'apache-' like dist ZIP/tar.gz instead of the
direct JAR file - not sure how well the mirrors (and anti virus
software) would like a direct JAR download.
This would need to include the bundle JAR inside with a README and
extract the NOTICE.
Please could you separate the different aspects from your new pull
request? Mixing NOTICE with comment fixes makes merging harder.
(And why aren't pull requests emailing dev@jena?)
Also - should a OSGi download ZIP also contain the other bundles it
depend on? (Similar to lib/ in the Jena distribution)? I am not sure
if this would be convenient or not for Non-Maven OSGi users.
It's not that big:
stain@biggie-utopic:~/src/jena/apache-jena-osgi/jena-osgi-test/target/eosgi-dist$
du -hs felix/lib
11M felix/lib
stain@biggie-utopic:~/src/jena/apache-jena-osgi/jena-osgi-test/target/eosgi-dist$
ls felix/lib/
commons-csv-1.0.jar jcl-over-slf4j-1.7.6.jar
org.everit.osgi.dev.testrunner.junit4-3.0.4.jar
commons-lang3-3.3.2.jar jena-osgi-2.13.0-SNAPSHOT.jar
org.ops4j.pax.tipi.hamcrest.core-1.3.0.1.jar
httpclient-osgi-4.2.6.jar jena-osgi-test-2.13.0-SNAPSHOT.jar
org.ops4j.pax.tipi.junit-4.11.0.1.jar
httpcore-osgi-4.2.5.jar jsonld-java-0.5.1.jar
slf4j-api-1.7.6.jar
jackson-annotations-2.3.0.jar libthrift-0.9.2.jar
slf4j-log4j12-1.7.6.jar
jackson-core-2.3.3.jar log4j-1.2.17.jar
jackson-databind-2.3.3.jar org.everit.osgi.dev.testrunner-4.0.3.jar
(The *-test and everit/ops4j bits wouldn't be in such a dist)
This reminds me - shouldn't jena-osgi include the additional notices
as in apache-jena/NOTICE?
In the jena-osgi-tidy pull-request I copy-pasted the relevant bits
(only Jena and Xerces bits) now to jena-osgi/META-INF/NOTICE
.. ideally this should be generated by Maven. Are there any others I forgot?
On 30 January 2015 at 15:02, Andy Seaborne <[email protected]> wrote:
https://github.com/apache/jena/pull/10
Conversations around this seem to have settled down around the latest state
of pull request 10 (to me as a non-OSGi person).
I propose to pull and merge this.
This message is lazy consensus (24hr minimum deadline) on pulling that so
that there will be a new module "jena-osgi".
Given it has to get into the build routine and settle down, I'd like to not
put decisions on the exact name onto the critical path for pulling the
request.
Naming:
1/ Should it be "apache-jena-osgi" as a delivery module?
2/ Or have a stable point apache-jena-osgi<type>pom</type> to point to
"jena-osgi"
3/ or leave it as jena-osgi and think about the name after 2.13.0 as
feedback comes in (i.e. a sort of "beta")
If there is an emerging consensus now on a different name, I'll do that else
put it in as jena-osgi and rename after due consideration.
We can then close:
https://issues.apache.org/jira/browse/JENA-190
Andy
