GitHub user stain opened a pull request:

    https://github.com/apache/jena/pull/37

    JENA-732 jena-maven-tools outputs to target/generated-sources/jena

    fixes JENA-731 and JENA-732
    
    This reverts the reverted commit by Benson Margulies so that generated 
sources are put in `target/generated-sources/jena` according to Maven plugin 
conventions, instead of straight into `target/generated-sources`.  (JENA-732)
    
    This also solves JENA-731 so that the source files are also compiled by 
Maven. I've therefore added tests to `src/it` to test for presence of the 
`*.class` files 
    
    .. except for where `<sources>` configuration has been overridden as in 
[schemagen-integration-2](https://github.com/stain/jena/blob/JENA-732-reborn/jena-maven-tools/src/it/schemagen-integration-2/verify.bsh#L31)
 - but should it perhaps also add those sources to the compile path? Other 
plugins like jaxb-maven-plugin usually do..

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stain/jena JENA-732-reborn

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jena/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #37
    
----
commit bdf57f582e4f55536d00932a7b057124516c59f8
Author: Stian Soiland-Reyes <st...@apache.org>
Date:   2015-02-26T00:32:29Z

    Revert "JENA-731 JENA-732: revert pending dicussion."
    
    This reverts commit 8532f01f41a016cb9ea1d27bfc25c9e13e5f6bbc.

commit f8a3b55793a12aa977015c8594fc81b2c0e26557
Author: Stian Soiland-Reyes <st...@apache.org>
Date:   2015-02-26T00:40:18Z

    JENA-732 Test generated source directory

commit 9d791a273e02df931646b1ddce9b0b60e3e0c4f7
Author: Stian Soiland-Reyes <st...@apache.org>
Date:   2015-02-26T00:49:30Z

    JENA-731: Test that target/classes also compiled the classes
    
    Discuss: Should it still add to compile path when <source> was
    overriden? It currently does not..

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to