GitHub user stain opened a pull request:
https://github.com/apache/jena/pull/49
Re-enable jena-osgi-tests
Re-enable the surefire-plugin for jena-osgi-tests - as the tests didn't
actually run on the master.
It needs an explicit <execution> so that it runs in a later phase. I've
added comments about this to the pom.
Now that the OSGi tests were running correctly, this highlighted a problem
from #45 in that Guava has an optional import on `sun.misc` which prevented
starting, so I added that as optional in our shading (as it is in the upstream
Guava `META-INF/MANIFEST.MF`).
I also re-added the explicit `<extensions>true</extensions>` as those were
added as a workaround for Maven 3.0.2 (see #32).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stain/jena osgi-tests-reenabled
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/49.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #49
----
commit dd0593fb1fdb87ec1fb247bd611404f204b827ed
Author: Stian Soiland-Reyes <[email protected]>
Date: 2015-03-31T00:16:07Z
Revert "Remove duplicate surefire plugin"
This reverts commit 3199dd1020e2f6ac06d49f2a230e5f9faad48382.
The surefire-plugin <execution> is needed to run the tests
in a later phase, after the OSGi bundle has been created
commit 60a07379220cf7e20e3c6c0769c8a3a4051ee97a
Author: Stian Soiland-Reyes <[email protected]>
Date: 2015-03-31T00:47:54Z
pom: Document <extensions> and <executions>
commit 820fb5e8b5b8eef319b9d2c3a4c65aa875505fb2
Author: Stian Soiland-Reyes <[email protected]>
Date: 2015-03-31T00:48:16Z
Only optionally import sun.misc
(coming from new dependency Guava)
commit 1a5914e0f0bacc3185f79fbe228b81bb158888a3
Author: Stian Soiland-Reyes <[email protected]>
Date: 2015-03-31T00:52:09Z
re-enable <extensions> for bundle-plugin for older Mavens
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
