On 06/05/15 22:30, A. Soroka wrote:
I've found another candidate for simplification (well, actually for
excision):
org.apache.jena.atlas.lib.cache contains several classes that
implement an interface org.apache.jena.atlas.lib.Cache. This
interface very closely resembles Guava's
com.google.common.cache.Cache, and I believe that the Guava type
could be substituted without too much fuss. The entire package
org.apache.jena.atlas.lib.cache could go away, along with the
Does this seem like a worthwhile replacement?
--- A. Soroka The University of Virginia Library
We do now use Guava cache (shaded) with the CacheGuava implementation of
Cache. The naming of getIfPresent or getOrFill was put in recently to
reflect the Guava design (and the safe atomic getOrFill is quite useful
sometimes - not always - TDB has "bi-caches" that need synhronized chnages).
Having our own Cache interface means different providers can be used.
We may find a better one for certain circumstances. The interface stops
guava-isms like RemovalNotification leaking out too far.
So on balance, I'm more inclined to keep it because we have the current
interface already.
Andy
