Github user osma commented on the pull request:
https://github.com/apache/jena/pull/53#issuecomment-110428103
Excellent! Looks good to me now, I'm in favor of merging this.
Only minor thing I noticed: there are now two places where the SHA-256
checksum is calculated. I suggest moving this functionality to the Entity class
(e.g. Entity.getUid()) so that the checksum logic is in only one place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
