I'll have to go back and review the dependency tree. The contract tests should only introduce: 1) a junit runner and associated annotations. 2) a maven mojo to report on the testing structure.
I think the client requirement comes in becaue there is a command line version of the mojo. I'll see what I can do about extracting that into a command line module separate from the main code -- shouldn't be hard. As for the non-apache licensed pieces.... is there a way to generate a list of them? All the xenei code is apache, the only other bits should be junit and maven mojo depdendencies. Claude On Thu, Jun 11, 2015 at 12:36 PM, Andy Seaborne <[email protected]> wrote: > On 19/05/15 20:25, Claude Warren wrote: > >> There is a set of contract tests (and test helpers) on the >> "add-contract-tests" branch. That branch works and has minimal change >> from >> the current tests. Those changes are adding the junit-contract runner and >> plugins. >> >> It makes no change to the execution. >> >> The problem that I am having is keeping it up to date with the current >> change rate of the Jena packages. Granted the contract tests are only >> implemented for the jena-core module, we have been keeing the entire suite >> up to date. >> >> Is there anyone that has any objection to moving the contract tests to the >> main code branch? >> >> Claude >> >> > Claude, > > There are some rough edges: > > 1/ The POM has been converted from spaces to tabs around commit 608c2b4 > > 2/ There are new dependencies, and recursive some are not Apache > Licensed. Is there anything that should go in LICENSE or NOTICE, even if > that comes via org.apache.maven? > > 3/ Why does testing depend on commons-cli? > > PR#76 proposes use of commons:common-cli (different version) > which caused me to see that. > > 4/ Can we have version mgt in jena-parent please? All other version mgt > or non-jena dependencies is done there (jena-* ones have to be done > explicitly for the release plug-in) > > Andy > -- I like: Like Like - The likeliest place on the web <http://like-like.xenei.com> LinkedIn: http://www.linkedin.com/in/claudewarren
