Seems like the only items remaining are to delte the LateBinding and EarlyBinding iterators as you suggested. I suppose we need to document that somehow so that integrators will know what to use if they have used those classes. Do we have a page tracking such changes?
On Tue, Jun 30, 2015 at 10:37 AM, Andy Seaborne <[email protected]> wrote: > On 29/06/15 21:19, Claude Warren wrote: > >> Looking at your changes they make perfect sense to me. >> > > Thanks for looking at it. > > I've done "option 1" (extends NiceIterator) which means it does the same > thing but the LazyIterator code does not repeat code from NiceIterator. > > Andy > > > >> On Mon, Jun 29, 2015 at 5:31 PM, Andy Seaborne <[email protected]> wrote: >> >> On 29/06/15 17:05, Claude Warren wrote: >>> >>> I'll have to mess with the build when I get home. >>>> >>>> As for the iteraor solution --- I am not at all certain why there was a >>>> problem. >>>> >>>> >>>> >>> It sounded like the generic solution was starting the process too >>>> soon. But I didn't really follow. I'll look tonight and see if I can >>>> follow your logic. >>>> >>>> >>> RIOT and Elephas test suites had failures in them when testing their use >>> of RDF/XML. >>> >>> The RIOT writer tests include some nasty corner cases for Turtle (things >>> that aren't well formed RDF lists). The iterator changes broke the >>> RDF/XML >>> writer in cases where there were unprettiable RDF. >>> >>> The iterator filterKeep should build the sequence of iterators; the >>> RDF/XML Unparse assumed that it not materialise the lazy one when >>> filterKeep is called but when it is used via hasNext. >>> >>> Andy >>> >>> >>> >>> Claude >>>> >>>> On Mon, Jun 29, 2015 at 4:42 PM, Andy Seaborne <[email protected]> wrote: >>>> >>>> On 29/06/15 09:57, Claude Warren wrote: >>>> >>>>> >>>>> The contract-test-maven-plugin should be version 0.1.4 >>>>> >>>>>> >>>>>> >>>>>> Maven disagrees with you :-) >>>>> >>>>> That's the job output so something is wrong in the setup ... >>>>> >>>>> jena-parent : nothing in the pluginManagemen section but there is a >>>>> dependency (which should not be in dependency if it's a plugin?) >>>>> >>>>> <dependency> >>>>> <groupId>org.xenei</groupId> >>>>> <artifactId>contract-test-maven-plugin</artifactId> >>>>> <version>0.1.2</version> >>>>> <scope>test</scope> >>>>> </dependency> >>>>> >>>>> and then in jena-core I see: >>>>> >>>>> <plugin> >>>>> <groupId>org.xenei</groupId> >>>>> <artifactId>contract-test-maven-plugin</artifactId> >>>>> <version>0.1.2</version> >>>>> >>>>> so 0.1.2 for contract-test-maven-plugin. >>>>> >>>>> -------------------------------------------- >>>>> >>>>> What do you think about the iterator fix? What I did was the minimum I >>>>> could see to get things to work, having spent a long time to actually >>>>> find >>>>> the bug. Complicated debugging ... not familiar with the unparser ... >>>>> seemly same code behaving differently! >>>>> >>>>> >>>>> >>>>> Andy >>>>> >>>>> >>>>> >>>>> [INFO] --- contract-test-maven-plugin:0.1.2:contract-test (default) @ >>>>> >>>>>> jena-core --- >>>>>> >>>>>> On Mon, Jun 29, 2015 at 9:50 AM, Apache Jenkins Server < >>>>>> [email protected]> wrote: >>>>>> >>>>>> See < >>>>>> >>>>>> >>>>>>> >>>>>>> >>>>>>> https://builds.apache.org/job/Jena_Development_Test_Windows/org.apache.jena$jena-core/589/changes >>>>>>> >>>>>>> >>>>>>> >>>>>>>> Changes: >>>>>>>> >>>>>>> >>>>>>> [andy] JENA-966 : filterKeep/filterDrop : Fix for laziness to apply >>>>>>> on >>>>>>> use. >>>>>>> >>>>>>> ------------------------------------------ >>>>>>> [INFO] >>>>>>> [INFO] >>>>>>> >>>>>>> >>>>>>> ------------------------------------------------------------------------ >>>>>>> [INFO] Building Apache Jena - Core 3.0.0-SNAPSHOT >>>>>>> [INFO] >>>>>>> >>>>>>> >>>>>>> ------------------------------------------------------------------------ >>>>>>> [INFO] Downloading: >>>>>>> >>>>>>> >>>>>>> >>>>>>> http://repository.apache.org/snapshots/org/apache/jena/jena-iri/3.0.0-SNAPSHOT/maven-metadata.xml >>>>>>> [INFO] Downloaded: >>>>>>> >>>>>>> >>>>>>> >>>>>>> http://repository.apache.org/snapshots/org/apache/jena/jena-iri/3.0.0-SNAPSHOT/maven-metadata.xml >>>>>>> (2 KB at 0.8 KB/sec) >>>>>>> [INFO] Downloading: >>>>>>> >>>>>>> >>>>>>> >>>>>>> http://repository.apache.org/snapshots/org/apache/jena/jena-iri/3.0.0-SNAPSHOT/jena-iri-3.0.0-20150628.202132-58.pom >>>>>>> [INFO] Downloaded: >>>>>>> >>>>>>> >>>>>>> >>>>>>> http://repository.apache.org/snapshots/org/apache/jena/jena-iri/3.0.0-SNAPSHOT/jena-iri-3.0.0-20150628.202132-58.pom >>>>>>> (4 KB at 18.7 KB/sec) >>>>>>> [INFO] Downloading: >>>>>>> >>>>>>> >>>>>>> >>>>>>> http://repository.apache.org/snapshots/org/apache/jena/jena-iri/3.0.0-SNAPSHOT/jena-iri-3.0.0-20150628.202132-58.jar >>>>>>> [INFO] Downloaded: >>>>>>> >>>>>>> >>>>>>> >>>>>>> http://repository.apache.org/snapshots/org/apache/jena/jena-iri/3.0.0-SNAPSHOT/jena-iri-3.0.0-20150628.202132-58.jar >>>>>>> (135 KB at 233.2 KB/sec) >>>>>>> [INFO] >>>>>>> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ jena-core >>>>>>> --- >>>>>>> [INFO] >>>>>>> [INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce) @ jena-core >>>>>>> --- >>>>>>> [INFO] >>>>>>> [INFO] --- apache-rat-plugin:0.11:check (rat-checks) @ jena-core --- >>>>>>> [INFO] 51 implicit excludes (use -debug for more details). >>>>>>> [INFO] Exclude: **/src-examples/data/* >>>>>>> [INFO] Exclude: **/dist/ABOUT >>>>>>> [INFO] Exclude: **/SEE_FUSEKI2 >>>>>>> [INFO] Exclude: **/src/main/webapp/css/* >>>>>>> [INFO] Exclude: **/src/main/webapp/fonts/* >>>>>>> [INFO] Exclude: **/src/main/webapp/js/**/* >>>>>>> [INFO] Exclude: **/vocabularies/* >>>>>>> [INFO] Exclude: **/Vocabularies/* >>>>>>> [INFO] Exclude: **/src/main/**/*.html >>>>>>> [INFO] Exclude: **/src/**/package-info.java >>>>>>> [INFO] Exclude: **/DEPENDENCIES >>>>>>> [INFO] Exclude: **/*.txt >>>>>>> [INFO] Exclude: **/*.md >>>>>>> [INFO] Exclude: **/META-INF/services/* >>>>>>> [INFO] Exclude: **/src/test/resources/**/* >>>>>>> [INFO] Exclude: **/testing/**/* >>>>>>> [INFO] Exclude: **/log4j.properties >>>>>>> [INFO] Exclude: **/log4j-testing.properties >>>>>>> [INFO] Exclude: **/derby.log >>>>>>> [INFO] Exclude: **/DB/**/* >>>>>>> [INFO] Exclude: **/tdb*.cfg >>>>>>> [INFO] Exclude: **/run/**/* >>>>>>> [INFO] Exclude: **/*.classpath >>>>>>> [INFO] Exclude: **/target/**/* >>>>>>> [INFO] Exclude: **/dependency-reduced-pom.xml >>>>>>> [INFO] 1166 resources included (use -debug for more details) >>>>>>> Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: >>>>>>> Property >>>>>>> ' >>>>>>> http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is >>>>>>> not >>>>>>> recognized. >>>>>>> Compiler warnings: >>>>>>> WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property ' >>>>>>> http://javax.xml.XMLConstants/property/accessExternalDTD' is not >>>>>>> recognized.' >>>>>>> Warning: org.apache.xerces.parsers.SAXParser: Feature ' >>>>>>> http://javax.xml.XMLConstants/feature/secure-processing' is not >>>>>>> recognized. >>>>>>> Warning: org.apache.xerces.parsers.SAXParser: Property ' >>>>>>> http://javax.xml.XMLConstants/property/accessExternalDTD' is not >>>>>>> recognized. >>>>>>> Warning: org.apache.xerces.parsers.SAXParser: Property ' >>>>>>> http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is >>>>>>> not >>>>>>> recognized. >>>>>>> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 >>>>>>> generated: 0 >>>>>>> approved: 1155 licence. >>>>>>> [INFO] >>>>>>> [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ >>>>>>> jena-core >>>>>>> --- >>>>>>> [INFO] >>>>>>> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ >>>>>>> jena-core --- >>>>>>> [INFO] Using 'UTF-8' encoding to copy filtered resources. >>>>>>> [INFO] Copying 2 resources to etc >>>>>>> [INFO] Copying 19 resources >>>>>>> [INFO] Copying 1 resource >>>>>>> [INFO] Copying 3 resources >>>>>>> [INFO] >>>>>>> [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ >>>>>>> jena-core >>>>>>> --- >>>>>>> [INFO] Changes detected - recompiling the module! >>>>>>> [INFO] Compiling 721 source files to >>>>>>> >>>>>>> >>>>>>> >>>>>>> F:\jenkins\jenkins-slave\workspace\Jena_Development_Test_Windows\jena-core\target\classes >>>>>>> [WARNING] >>>>>>> >>>>>>> >>>>>>> >>>>>>> /F:/jenkins/jenkins-slave/workspace/Jena_Development_Test_Windows/jena-core/src/main/java/org/apache/jena/rdf/model/impl/RDFReaderFImpl.java: >>>>>>> Some input files use or override a deprecated API. >>>>>>> [WARNING] >>>>>>> >>>>>>> >>>>>>> >>>>>>> /F:/jenkins/jenkins-slave/workspace/Jena_Development_Test_Windows/jena-core/src/main/java/org/apache/jena/rdf/model/impl/RDFReaderFImpl.java: >>>>>>> Recompile with -Xlint:deprecation for details. >>>>>>> [INFO] >>>>>>> [INFO] --- maven-resources-plugin:2.6:testResources >>>>>>> (default-testResources) @ jena-core --- >>>>>>> [INFO] Using 'UTF-8' encoding to copy filtered resources. >>>>>>> [INFO] Copying 33 resources >>>>>>> [INFO] Copying 3 resources >>>>>>> [INFO] >>>>>>> [INFO] --- maven-compiler-plugin:3.1:testCompile >>>>>>> (default-testCompile) >>>>>>> @ >>>>>>> jena-core --- >>>>>>> [INFO] Changes detected - recompiling the module! >>>>>>> [INFO] Compiling 402 source files to >>>>>>> >>>>>>> >>>>>>> >>>>>>> F:\jenkins\jenkins-slave\workspace\Jena_Development_Test_Windows\jena-core\target\test-classes >>>>>>> [WARNING] >>>>>>> >>>>>>> >>>>>>> >>>>>>> /F:/jenkins/jenkins-slave/workspace/Jena_Development_Test_Windows/jena-core/src/test/java/jena/test/Test_rdfcat.java: >>>>>>> Some input files use or override a deprecated API. >>>>>>> [WARNING] >>>>>>> >>>>>>> >>>>>>> >>>>>>> /F:/jenkins/jenkins-slave/workspace/Jena_Development_Test_Windows/jena-core/src/test/java/jena/test/Test_rdfcat.java: >>>>>>> Recompile with -Xlint:deprecation for details. >>>>>>> [INFO] >>>>>>> [INFO] --- contract-test-maven-plugin:0.1.2:contract-test (default) @ >>>>>>> jena-core --- >>>>>>> [INFO] Processing package: org.apache.jena.assembler >>>>>>> [INFO] Processing package: org.apache.jena.datatypes >>>>>>> [INFO] Processing package: org.apache.jena.enhanced >>>>>>> [INFO] Processing package: org.apache.jena.graph >>>>>>> [INFO] Processing package: org.apache.jena.mem >>>>>>> [INFO] Processing package: org.apache.jena.n3 >>>>>>> [INFO] Processing package: org.apache.jena.ontology >>>>>>> [INFO] Processing package: org.apache.jena.rdf >>>>>>> [INFO] Processing package: org.apache.jena.rdfxml >>>>>>> [INFO] Processing package: org.apache.jena.reasoner >>>>>>> [INFO] Processing package: org.apache.jena.shared >>>>>>> [INFO] Processing package: org.apache.jena.util >>>>>>> [INFO] Processing package: org.apache.jena.vocabulary >>>>>>> [INFO] Skip filter: Not( Wildcard( Sensitive, *.test.* ) ) >>>>>>> [JENKINS] Archiving disabled >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>> >>>> >>>> >>> >> >> > -- I like: Like Like - The likeliest place on the web <http://like-like.xenei.com> LinkedIn: http://www.linkedin.com/in/claudewarren
