[ 
https://issues.apache.org/jira/browse/JENA-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14729807#comment-14729807
 ] 

ASF GitHub Bot commented on JENA-1019:
--------------------------------------

GitHub user ramiromagalhaes opened a pull request:

    https://github.com/apache/jena/pull/92

    Making Model attributes private and final in many vocabulary classes.

    As requested in https://issues.apache.org/jira/browse/JENA-1019, here is my 
change proposal.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ramiromagalhaes/jena master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jena/pull/92.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #92
    
----
commit d0f9daa4b9dcbf7678917cf404debdb8ba1c6485
Author: Ramiro Pereira de Magalhães <[email protected]>
Date:   2015-09-03T21:13:03Z

    Making Model attributes private and final in many vocabulary classes.

----


> Shouldn't org.apache.jena.vocabulary.SKOS.m be final?
> -----------------------------------------------------
>
>                 Key: JENA-1019
>                 URL: https://issues.apache.org/jira/browse/JENA-1019
>             Project: Apache Jena
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: Jena 3.0.0
>            Reporter: Ramiro Pereira de Magalhães
>            Priority: Minor
>
> In org.apache.jena.vocabulary.SKOS, the static member "m" is not final. Is it 
> intentional? It seems to me that it should be a public static final value.
> Should the same be applied to classes DC_11.m_model, DCTerms.m_model, and 
> other classes?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to