I don’t think so, because I was running those from the beginning. Just to be 
clear, the suite of tests for DatasetGraphInMemory is in 
TestDatasetGraphInMemory:

https://github.com/ajs6f/jena/blob/jena-624/jena-arq/src/test/java/org/apache/jena/sparql/core/mem/TestDatasetGraphInMemory.java

and it now includes:

AbstractDatasetGraphTests
TestDatasetGraphWithLock < AbstractTestDataset
TestDatasetGraphViewGraphs < AbstractTestGraphOverDataset
AbstractTestTransaction

and of course tests specific to DatasetGraphInMemory, mostly threading tests. 
I’ve committed to my branch a simple implementation of prefix management using 
a ConcurrentHashMap<String, PrefixMapping> and a sanity check test in 
TestDatasetGraphInMemory that prefixes work.

---
A. Soroka
The University of Virginia Library

> On Sep 25, 2015, at 10:13 AM, Andy Seaborne <[email protected]> wrote:
> 
> On 25/09/15 12:53, A. Soroka wrote:
>> Ah, cool— glad you mentioned this. I was about to add a “manages
>> prefixes reasonably" test to AbstractDatasetGraphTests. Instead I’ll
>> leave it in the in-memory-dsg-specific tests, unless you think it
>> work breaking out into its own class for reuse?
> 
> AbstractTestGraphOverDataset may have some.
> 
>       Andy
> 
>> 
>> --- A. Soroka The University of Virginia Library
>> 
>>> On Sep 25, 2015, at 7:49 AM, Andy Seaborne <[email protected]>
>>> wrote:
>>> 
>>>> 3) It didn’t even occur to me to manage prefixes (prefixen?). I
>>>> didn’t realize that was a Dataset responsibility, although that
>>>> certainly makes sense. Well, that’s why we don’t make
>>>> assumptions! {grin} I’ll fix that based on DatasetPrefixStorage.
>>> 
>>> It's not an absolute requirement but it is nice to do it.
>> 
> 

Reply via email to