[ 
https://issues.apache.org/jira/browse/JENA-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991799#comment-14991799
 ] 

ASF GitHub Bot commented on JENA-1062:
--------------------------------------

Github user osma commented on the pull request:

    https://github.com/apache/jena/pull/97#issuecomment-154092054
  
    Thanks @ajs6f for your detailed notes! I fixed the things you pointed out 
but I think especially the Guava Sets.newHashSet pattern could be applied in 
many other places in the jena-text code as well. My test case code was just 
adapted from similar other jena-text tests and they all use the same pattern. 
Fixing those as well isn't really in the scope for this PR but could be done 
separately.


> add ConfigurableAnalyzer to jena-text
> -------------------------------------
>
>                 Key: JENA-1062
>                 URL: https://issues.apache.org/jira/browse/JENA-1062
>             Project: Apache Jena
>          Issue Type: New Feature
>          Components: Text
>            Reporter: Osma Suominen
>            Assignee: Osma Suominen
>
> This is an alternative to JENA-1058 (which implemented a very specific Lucene 
> Analyzer for jena-text). The idea here, based on a comment by Claude Warren 
> on JENA-1058, is to provide a ConfigurableAnalyzer that can be configured 
> with a Tokenizer and (optionally) one or more TokenFilters, like this:
> text:analyzer [
>   a text:ConfigurableAnalyzer ;
>   text:tokenizer text:KeywordTokenizer ;
>   text:filters (text:ASCIIFoldingFilter, text:LowerCaseFilter)
> ]
> I have some code ready to implement this and will open a PR shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to