[jira] [Commented] (JENA-1078) TxnMem does not log a warning when commit() omitted.

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/JENA-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048516#comment-15048516
 ] 

ASF GitHub Bot commented on JENA-1078:
--------------------------------------

Github user afs commented on a diff in the pull request:

    https://github.com/apache/jena/pull/105#discussion_r47078789
  
    --- Diff: 
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java
 ---
    @@ -161,17 +161,17 @@ public void abort() {
        @Override
        public void close() {
                if (isInTransaction()) abort();
    -
        }
     
        @Override
        public void end() {
             if (isInTransaction()) {
    +            log.warn("Ending transaction without commit!");
    --- End diff --
    
    begin(READ)-end() is a normal pattern.  The code needs to know if it is 
considering a READ or WRITE transaction.


> TxnMem does not log a warning when commit() omitted.
> ----------------------------------------------------
>
>                 Key: JENA-1078
>                 URL: https://issues.apache.org/jira/browse/JENA-1078
>             Project: Apache Jena
>          Issue Type: Bug
>    Affects Versions: Jena 3.0.1
>            Reporter: Andy Seaborne
>             Fix For: Jena 3.1.0
>
>
> Example:
> {noformat}
>       Dataset ds = DatasetFactory.createTxnMem() ;
>       //Dataset ds = TDBFactory.createDataset() ;
>       ds.begin(ReadWrite.WRITE) ;
>       //ds.commit();
>       ds.end() ;
> {noformat}
> whereas a read transaction can be:
> {noformat}
>       Dataset ds = DatasetFactory.createTxnMem() ;
>       ds.begin(ReadWrite.READ) ;
>       ds.end() ;
> {noformat}
> See javadoc for {{org.apache.jena.sparql.core.Transactional}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)