Github user samaitra commented on the pull request:

    https://github.com/apache/jena/pull/95#issuecomment-166005604
  
    @afs Thank you Andy for feedback. I have updated the files as per 
discussion.
    
    **Cache per dataset**
    
    Updated getCache() to getCache(String uri) which will accept dataset uri.
    
    **No Cache**
    
    If SPARQL_QueryDataset is directly used then read will not happen from 
cache but Query results will be written to cache. So, SPARQL_QueryDataset can 
be directly used as well.
    
     **Cache key**
    
    Updated cache key to `query + responseType.getContentType()`
    
     **Inherit to share code**
    
    Updated SPARQL_Query_Cache to extend SPARQL_QueryDataset and removed the 
duplicate methods. Also changed SPARQL_Query call to use
        ```
            super.execute(....)
        ```  
    
    
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to