Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/120#discussion_r49192464
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/PMapQuadTable.java ---
@@ -37,13 +39,29 @@
* use.
*
*/
-public abstract class PMapQuadTable extends PMapTupleTable<FourTupleMap,
Quad>implements QuadTable {
+public class PMapQuadTable extends PMapTupleTable<FourTupleMap, Quad,
Consumer4<Node>>implements QuadTable {
+
+
+ private static class QuadTupleMap extends TupleMap {
+
+ private QuadTupleMap(final String mappedOrder) {
+ super(mappedOrder, compileMapping("GSPO", mappedOrder));
+ }
+ }
+
--- End diff --
It seems significantly clearer to me this way (the `static` methods just
delegate to constructors, and it's clear from the outside that they must) but I
have no problem doing it the other way. I'll add a commit "resetting"
`TupleMap` and using `static`s later today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
