[
https://issues.apache.org/jira/browse/JENA-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114345#comment-15114345
]
ASF GitHub Bot commented on JENA-1122:
--------------------------------------
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/123#issuecomment-174309243
As far as I can see, only an assembler solution will address
[JENA-1122](https://issues.apache.org/jira/browse/JENA-1122). @bwmcbride - do
you believe this PR alone will address JENA-1122? Has this PR been run under
load?
By protecting the text index alone, I see a new class of concurrency issues
arising. A shared text index between two different TDB datasets will go wrong
on update. At the moment, you can't create that setup because of JENA-1104.
Other setups will have concurrency problems.
*If* this works in a "one dataset, must be TDB, only in Fuseki" setup, it
only protects against
[JENA-1104](https://issues.apache.org/jira/browse/JENA-1104). If then use of
TDB happens to work at the moment, it is based on internal implementation
handling in Fuseki. That is very fragile.
This PR does no harm though it is a bit more complicated than needed
because a solution to the root cause
[JENA-1122](https://issues.apache.org/jira/browse/JENA-1122) may well remove
the need for some of the machinery.
> Fuseki fails to start if configured with two services that share the same
> dataset with a lucene index.
> ------------------------------------------------------------------------------------------------------
>
> Key: JENA-1122
> URL: https://issues.apache.org/jira/browse/JENA-1122
> Project: Apache Jena
> Issue Type: Bug
> Components: Text
> Affects Versions: Jena 3.0.0, Fuseki 2.3.0
> Reporter: Brian McBride
>
> This problem arises when the assemblers for the two services run. For each
> service, a separate TextIndexLucene object is created. Both of those objects
> try to lock the same Lucene index directory and one fails.
> A proposed fix is to modify the TextDatasetFactory to only create one
> TextIndexLucene object per on disk directory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
