[
https://issues.apache.org/jira/browse/JENA-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182945#comment-15182945
]
ASF GitHub Bot commented on JENA-1147:
--------------------------------------
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/128#discussion_r55195636
--- Diff:
jena-arq/src/main/java/org/apache/jena/riot/system/FactoryRDF.java ---
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.jena.riot.system;
+
+import org.apache.jena.datatypes.RDFDatatype ;
+import org.apache.jena.graph.Graph ;
+import org.apache.jena.graph.Node ;
+import org.apache.jena.graph.Triple ;
+import org.apache.jena.sparql.core.DatasetGraph ;
+import org.apache.jena.sparql.core.Quad ;
+
+/**
+ * Create core RDF objects: {@link Node}s, {@link Triple}s, {@link Quad}s,
+ * {@link Graph}, {@link DatasetGraph}s.
+ * <p>
+ */
+public interface FactoryRDF {
+ // ?? Are these too varied?
+ public Graph createGraph() ;
+ // ?? Are these too varied?
+ public DatasetGraph createDatasetGraph() ;
+ public Triple createTriple(Node subject, Node predicate, Node object) ;
+ public Quad createQuad(Node graph, Node subject, Node predicate, Node
object) ;
+ public Node createURI(String uriStr) ;
+ public Node createTypedLiteral(String lexical, RDFDatatype datatype) ;
+ public Node createLangLiteral(String lexical, String langTag) ;
+ public Node createStringLiteral(String lexical) ;
+ /** Create a blank node */
+ public Node createBlankNode() ;
--- End diff --
Do we want something for `BlankNodeId` here?
> Add a node cache step to RIOT parsing.
> --------------------------------------
>
> Key: JENA-1147
> URL: https://issues.apache.org/jira/browse/JENA-1147
> Project: Apache Jena
> Issue Type: Improvement
> Components: RIOT
> Affects Versions: Jena 3.0.1
> Reporter: Andy Seaborne
> Assignee: Andy Seaborne
> Priority: Minor
>
> A node cache on the parsing pipeline will reduce memory footprint.
> It may be worth doing different caches for subject/predicate/object as they
> have different characteristics.
> Care is needed because sometimes the parser is not creating stored object
> (e.g. TDB loading) so the cache should measurable not add overhead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
