Github user osma commented on the pull request:
https://github.com/apache/jena/pull/146#issuecomment-219381471
Thanks for the PR!
The code looks good, as you say it's following the pattern established by
JENA-1134.
You are right about the unit tests - the inheritance hierarchy of
analyzer-related unit tests is rather messy. There is a very long inheritance
chain and e.g. TestDatasetWithAnalyzingQueryParser indirectly inherits from
TestDatasetWithKeywordAnalyzer. There is actually a sort of logic here, because
the tests specified in TestDatasetWithKeywordAnalyzer will also be run on the
subclasses, as the analyzer configurations are compatible. This gives us some
unit tests "for free".
I did some reorganizing of the test classes, namely, I abstracted out
AbstractTestDatasetWithAnalyzer from TestDatasetWithKeywordAnalyzer (see
https://github.com/apache/jena/commit/8a20f238ffc5aed23648b038132fe74cbca2c85c).
Unless I'm missing ssomething, you should now be able to inherit from
AbstractTestDatasetWithAnalyzer and avoid doing the full makeSpec in your test
class. Would you mind switching over to that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
