[ https://issues.apache.org/jira/browse/JENA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371430#comment-15371430 ]
ASF GitHub Bot commented on JENA-576: ------------------------------------- Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/151 Reading through the current HTTP Commons docs leaves me with the impression that we do not need to close clients after use in `HttpOp`, but that we do need to see to it that _responses_ are closed. However, tracing through to `oaj.riot.web.HttpResponseLib.nullResponse` in conjunction with advice [here](https://hc.apache.org/httpcomponents-client-ga/tutorial/html/fundamentals.html#d5e145) assures me that we are doing what we need to do. The only case that I find uncertain is in methods like `TypedInputStream execHttpGet(String url)` wherein we really cannot be sure that the request is properly closed. I'm not sure what to do about this short of trying to take `HttpOp` completely internal, which seems like a massive overreaction. > Upgrade Apache HTTP Client to 4.3 > --------------------------------- > > Key: JENA-576 > URL: https://issues.apache.org/jira/browse/JENA-576 > Project: Apache Jena > Issue Type: Dependency upgrade > Components: ARQ > Affects Versions: Jena 2.11.0 > Reporter: Rob Vesse > Assignee: Rob Vesse > Priority: Minor > Original Estimate: 72h > Remaining Estimate: 72h > > As of 2.11.0 ARQ centralizes all HTTP operations through HttpOp which relies > on Apache HTTP Client. Currently we are using 4.2.3 while the latest stable > release is actually 4.3.1 > Therefore we should look at upgrading our code to use the latest version > which may entail some refactoring since there appears to have been some > breaking changes across the minor version bump which users have seen in usage > - e.g. > https://github.com/pyvandenbussche/sparqles/issues/9#issuecomment-27220738 -- This message was sent by Atlassian JIRA (v6.3.4#6332)