Github user Claudenw commented on a diff in the pull request:
https://github.com/apache/jena/pull/176#discussion_r82511501
--- Diff:
jena-permissions/src/main/java/org/apache/jena/permissions/impl/SecuredItemImpl.java
---
@@ -299,7 +299,7 @@ public String toString() throws
AuthenticationRequiredException {
* @return the value of the security check or <code>null</code> if the
value
* has not been cached.
*/
- private Boolean cacheGet(final CacheKey key) {
+ private static Boolean cacheGet(final CacheKey key) {
--- End diff --
What is the reasoning for making this a static method? While it is using
thread local only it seems to me that this is not semantically the same as a
static method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
