[
https://issues.apache.org/jira/browse/JENA-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611964#comment-15611964
]
ASF GitHub Bot commented on JENA-1252:
--------------------------------------
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/184#discussion_r85341210
--- Diff:
jena-arq/src/main/java/org/apache/jena/riot/tokens/TokenizerText.java ---
@@ -60,6 +61,26 @@
private boolean finished = false ;
private TokenChecker checker = null ;
+ // The code assumes that errors throw exception and so stop parsing.
+ private ErrorHandler errorHandler = new ErrorHandler() {
--- End diff --
Will do. It is stateless though a stateless object is not very expensive to
create!
The others are in ErrorHandlerFactory.
It maybe it becomes a parameter to the constructor.
Because letting dubious data through can lead to a lot of support load due
to downstream database problems, this PR just adds mechanism and does not
enable it. Hence it is keeping the default error handler in-file for now.
> Improve TokenizerText for warning/error handling.
> -------------------------------------------------
>
> Key: JENA-1252
> URL: https://issues.apache.org/jira/browse/JENA-1252
> Project: Apache Jena
> Issue Type: Improvement
> Components: RIOT
> Affects Versions: Jena 3.1.0
> Reporter: Andy Seaborne
> Assignee: Andy Seaborne
>
> Puts in place the structure for warnings not being tokenizer errors.
> This is not enabled - it needs testing to see what knock-on effects it has.
> Ideally, it should be combined with parsers that can do some level of error
> recovery.
> See also [email discussion on users@ (Nov
> 2016)|https://lists.apache.org/thread.html/0f16e1e124abde11dbf40a65e9858a9fadd5fb4d67bffc76fd528a1a@%3Cusers.jena.apache.org%3E].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
