Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/199#discussion_r93801320
--- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/StrUtils.java
---
@@ -33,32 +35,34 @@ private StrUtils() {}
/** strjoin with a newline as the separator */
public static String strjoinNL(String... args) {
- return join("\n", args);
+ return String.join("\n", args);
}
/** strjoin with a newline as the separator */
public static String strjoinNL(List<String> args) {
- return join("\n", args);
+ return String.join("\n", args);
}
- /** Concatentate strings, using a separator */
+ /**
+ * Concatentate strings, using a separator
+ *
+ * @deprecated Prefer String.join(sep, args)
+ */
+ @Deprecated
--- End diff --
If we are going to deprecate this, then I really would like to see the
changes propagated through the codebase, not left pending.
Currently, at least for me, Jena is warning free in the main modules so I
can see when warnings appear. Having unfinished deprecations means that it is
harder to notice warnings appearing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
