Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/202#discussion_r95081992
--- Diff:
jena-base/src/main/java/org/apache/jena/atlas/lib/CollectionUtils.java ---
@@ -22,12 +22,7 @@
public class CollectionUtils
{
- public static <T> boolean disjoint(Collection<T> c1, Collection<T> c2)
- {
- return c1.stream().noneMatch(c2::contains);
- }
-
- /** Test for same elements, regarless of cardinality */
+ /** Test for same elements, regardless of cardinality */
public static <T> boolean sameElts(Collection<T> left, Collection<T>
right) {
--- End diff --
You know, you would think there would be, but I didn't find anything that
ignores both cardinality and order and works for all `Collection`s. OTOH, I
just check and nothing in Jena actually _uses_ this function except its own
tests! So I wouldn't be averse to just dropping it. Anyone who was using it
should have no difficulty in-lining it or inserting their own.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
