[ 
https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926005#comment-15926005
 ] 

ASF GitHub Bot commented on JENA-1305:
--------------------------------------

Github user osma commented on a diff in the pull request:

    https://github.com/apache/jena/pull/227#discussion_r106143930
  
    --- Diff: 
jena-text/src/main/java/org/apache/jena/query/text/assembler/TextAssembler.java 
---
    @@ -29,14 +29,15 @@ public static void init()
             AssemblerUtils.registerDataset(TextVocab.textDataset,      new 
TextDatasetAssembler()) ;
             
             Assembler.general.implementWith(TextVocab.entityMap,        new 
EntityDefinitionAssembler()) ;
    -        Assembler.general.implementWith(TextVocab.textIndexSolr,    new 
TextIndexSolrAssembler()) ; 
             Assembler.general.implementWith(TextVocab.textIndexLucene,  new 
TextIndexLuceneAssembler()) ;
             Assembler.general.implementWith(TextVocab.standardAnalyzer, new 
StandardAnalyzerAssembler()) ;
             Assembler.general.implementWith(TextVocab.simpleAnalyzer,   new 
SimpleAnalyzerAssembler()) ;
             Assembler.general.implementWith(TextVocab.keywordAnalyzer,  new 
KeywordAnalyzerAssembler()) ;
             
Assembler.general.implementWith(TextVocab.lowerCaseKeywordAnalyzer, new 
LowerCaseKeywordAnalyzerAssembler()) ;
             Assembler.general.implementWith(TextVocab.localizedAnalyzer, new 
LocalizedAnalyzerAssembler()) ;
             Assembler.general.implementWith(TextVocab.configurableAnalyzer, 
new ConfigurableAnalyzerAssembler()) ;
    +        Assembler.general.implementWith(TextVocab.textIndexES,  new 
TextIndexESAssembler()) ;
    --- End diff --
    
    minor style issue, but please move this next to TextIndexLuceneAssembler a 
few lines up, because they're similar


> Elastic Search Support for Apache Jena Text 
> --------------------------------------------
>
>                 Key: JENA-1305
>                 URL: https://issues.apache.org/jira/browse/JENA-1305
>             Project: Apache Jena
>          Issue Type: New Feature
>          Components: Text
>    Affects Versions: Jena 3.2.0
>            Reporter: Anuj Kumar
>            Assignee: Osma Suominen
>              Labels: elasticsearch
>   Original Estimate: 240h
>  Remaining Estimate: 240h
>
> This Jira tracks the development of Jena Text ElasticSearch Implementation.
> The goal is to extend Jena Text capability to index, at scale, in 
> ElasticSearch. This implementation would be similar to the Lucene and Solr 
> implementations.
> We will use ES version 5.2.1 for the implementation.
> The following functionalities would be supported:
> * Indexing Literal values
> * Updating indexed values
> * Deleting Indexed values
> * Custom Analyzer Support
> * Configuration using Assembler as well as Java techniques.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to