[ 
https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926029#comment-15926029
 ] 

Osma Suominen commented on JENA-1305:
-------------------------------------

Hi [~anujkumar]

I was doing a review while you changed the code - whoops! This is the first 
time I've used the (quite new) GitHub Review functionality - I hope I did it 
right! It seems to have produced quite a lot of output into this JIRA issue, oh 
my! Sorry about that.

I don't have time anymore to go through your latest changes right now but can 
you please look through my review commits and when you're done with them, I can 
do a second round of review. I will also request that other Jena developers 
take a look once the code seems closer to merging.

The things I'm most worried about are how the code works in non-multilingual 
mode and the potential race conditions in how updates and deletes are handled. 
Everything else is pretty much cosmetic, still important to do before merging 
but should be easy to fix I think.

> Elastic Search Support for Apache Jena Text 
> --------------------------------------------
>
>                 Key: JENA-1305
>                 URL: https://issues.apache.org/jira/browse/JENA-1305
>             Project: Apache Jena
>          Issue Type: New Feature
>          Components: Text
>    Affects Versions: Jena 3.2.0
>            Reporter: Anuj Kumar
>            Assignee: Osma Suominen
>              Labels: elasticsearch
>   Original Estimate: 240h
>  Remaining Estimate: 240h
>
> This Jira tracks the development of Jena Text ElasticSearch Implementation.
> The goal is to extend Jena Text capability to index, at scale, in 
> ElasticSearch. This implementation would be similar to the Lucene and Solr 
> implementations.
> We will use ES version 5.2.1 for the implementation.
> The following functionalities would be supported:
> * Indexing Literal values
> * Updating indexed values
> * Deleting Indexed values
> * Custom Analyzer Support
> * Configuration using Assembler as well as Java techniques.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to