Github user ajs6f commented on the issue:

    https://github.com/apache/jena/pull/227
  
    I don't know enough to have a useful opinion about how thorough the tests 
need to be-- I am very happy to defer to @osma about that.
    
    As for the test framework-- my (small) knowledge of ES encourages me to 
agree that we want to avoid relying on the embedded mode if at _all_ possible. 
If we have to use it, we should immediately open an additional Jena ticket to 
get rid of it! :disappointed: It seems just as well to me to avoid relying on 
the ES test framework, not because I think it is inherently problematic, but 
because it introduces another piece of software that has to be understood to 
maintain this new functionality.
    
    In case it's not obvious @anujgandharv (although I am guessing it is) @osma 
and I are very concerned to both get this new code merged, but to do it in such 
a way that we can reasonably expect to maintain it. With a fairly small 
all-volunteer body of maintainers, that is a very real and concrete concern.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to