I applied those changes (from the cancel_sort branch) by diff/apply patching so that would have lost its identity as commit bf6d15f.I've just checked that all the changes from that commit are visible in the cancel-sort-cj branch.
[Doing the update by patching was clearly the wrong thing to do, I now can't remember the "completely logical" reasons for doing so.] So epimorphics/jena branch cancel-sort-cj contains all the changes we have been discussing. Chris On 20 April 2017 at 21:29, Andy Seaborne <[email protected]> wrote: > I don't see commit bf6d15f (April 14) on there. > Did you do your own changes? independently apply PR#239? > > Andy > > > On 20/04/17 15:44, Chris Dollin wrote: > >> I have a branch cancel-sort-cj of epimorphics/jana (which is a fork >> of apache jena) with you(andy)r changes for open and mine for >> adding some tests. >> >> Once I've double-eyeballed it, should I then make a pull >> request? >> >> Chris >> >> >> On 19 April 2017 at 09:34, ASF GitHub Bot (JIRA) <[email protected]> wrote: >> >> >>> [ https://issues.apache.org/jira/browse/JENA-1320?page= >>> com.atlassian.jira.plugin.system.issuetabpanels:comment- >>> tabpanel&focusedCommentId=15974316#comment-15974316 ] >>> >>> ASF GitHub Bot commented on JENA-1320: >>> -------------------------------------- >>> >>> Github user ehedgehog commented on the issue: >>> >>> https://github.com/apache/jena/pull/239 >>> >>> Those changes look OK to me. >>> >>> I have further changes (built on those) to add tests for closing >>> QueryIterSort and >>> QueryIterTopN -- how should I supply/apply those? >>> >>> Chris >>> >>> >>> >>> Open iterators reported when cancelling a query during sorting >>>> -------------------------------------------------------------- >>>> >>>> Key: JENA-1320 >>>> URL: https://issues.apache.org/jira/browse/JENA-1320 >>>> Project: Apache Jena >>>> Issue Type: Bug >>>> Components: ARQ >>>> Affects Versions: Jena 3.2.0 >>>> Reporter: Andy Seaborne >>>> >>>> "Bug in SortedDataBag?" >>>> https://lists.apache.org/thread.html/be3ecf8f41b03a747f6bab78a072ca >>>> >>> 55b2ea1a07a6d7ae1e53600ac5@%3Cdev.jena.apache.org%3E >>> >>> >>> >>> -- >>> This message was sent by Atlassian JIRA >>> (v6.3.15#6346) >>> >>> >> >> >> -- "What I don't understand is this ..." Trevor Chaplin, /The Beiderbeck Affair/ Epimorphics Ltd, http://www.epimorphics.com Registered address: Court Lodge, 105 High Street, Portishead, Bristol BS20 6PT Epimorphics Ltd. is a limited company registered in England (number 7016688)
