Github user osma commented on the issue:
https://github.com/apache/jena/pull/246
@xristy Thanks for the excellent explanation about the background for this
PR! As you said, this came a bit out of nowhere and it would perhaps had been
easier to get oriented if you had proposed it a bit beforehand on the dev list,
or filed the JIRA issue a little bit earlier, not just before the PR. But
clearly this is a well prepared PR and you have done an excellent job of
following the contribution guidelines, no fault with that.
As I see it, if there is a need (and you clearly have one!) for
functionality like this, the code looks good, and it doesn't make ongoing
maintenance more difficult, I don't see why we couldn't take it in.
Your suggestion of revising the jena-text documentation would be extremely
welcome. I've been concerned that it has been growing organically over time
when new features have been added, but the structure has not really kept up.
Also some Lucene features, such as wildcard queries, are not mentioned at all,
which may have caused misunderstandings about what the text index really can
do. At the minimum, linking to Lucene documentation about query syntax would
help, but revising the documentation to be more tutorial-like and perhaps
orienting it more around potential uses instead of individual features would
help a lot. If you can give a helping hand in that, I'd appreciate it a lot!
With a rather complex extension of existing functionality like this, we
would perhaps like to have some time for the code to get settled and work out
emerging issues. An additional complication currently is that we are just
trying to put together a release that already includes major changes to
jena-text (Lucene upgrade by two major versions, partial reimplementation of
the multilingual analyzer due to Lucene API changes, dropping Solr support and
introducing the Elasticsearch backend), it would perhaps be safer to wait until
after the release before merging this. On the other hand, I can see from the
commit stats that this is basically not touching existing code at all (zero
lines deleted), just adding to it, so it could be argued that this would be
unlikely to break existing functionality.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
